Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-thanos] - Allow bucket web httpPort specification #287

Conversation

gjtempleton
Copy link
Contributor

What this PR does / why we need it:

As of version 0.9 there was a rationalisation of startup of HTTP components of Thanos. This meant that the bucket web component moved from being served on port 8080 to 10902 as with the other HTTP components. (See thanos-io/thanos#1687). This isn't strictly necessary to still port-forward to the container as long as users correctly figure out the port however could lead to usability issues and issues with other tooling.

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped (if the pr is an update to an existing chart)
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

Signed-off-by: GuyTempleton <guy.templeton@skyscanner.net>
@monotek monotek merged commit 27b2423 into kiwigrid:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants