Store COINBASE in storage_var #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
force-pushed
the
cw/coinbase-storage-var
branch
from
8e28a39
to
9f38462
Compare
ClementWalter
force-pushed
the
cw/coinbase-storage-var
branch
from
9f38462
to
e36949a
Compare
enitrat
approved these changes
Apr 4, 2024
This was referenced Apr 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made coinbase storage var a constructor argument rather than a hardcoded value.
Time spent on this PR: 1 hour
(methodology: searched the whole source tree for "coinbase", "0xCA40", "precompiles", and "uninitialized")
Pull request type
What is the current behavior?
Currently Coinbase is a hardcoded constant value (0xCA40796aFB5472abaeD28907D5ED6FC74c04954a) duplicated in a few places in the .py and .cairo sources.
Resolves #1011
What is the new behavior?
That constant is now defined in a single location in constants.py and imported as needed. Accordingly, codebase is also passed as a new argument in the "kakarot" and "EVM" constructors.
This change is