-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add solidity formatter #1247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 65.47% 65.40% -0.08%
==========================================
Files 49 49
Lines 8281 8281
==========================================
- Hits 5422 5416 -6
- Misses 2859 2865 +6 ☔ View full report in Codecov by Sentry. |
Realizing that some external contracts are copy/pasted for tests in the src directory, One solution in the meantime to avoid applying the forge fmt to them is to use the ignore for forge fmt. |
@enitrat should we just ignore or upgrade to have these files as submodule?
|
a273e1d
to
abcc68d
Compare
Let's go with 1. as this is low priority and impact |
@obatirou did you find any info on why uint -> uint256 ended up making the test fail? |
Unfortunately no, will try again this week |
Time spent on this PR: 0.5h
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1244
What is the new behavior?
This change is