Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whitelist 'compute_starknet_address' from reentrancy #1254

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Jul 4, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?


This change is Reviewable

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.

Project coverage is 64.02%. Comparing base (59835a7) to head (cd02218).

Files Patch % Lines
src/kakarot/errors.cairo 9.52% 19 Missing ⚠️
src/kakarot/precompiles/kakarot_precompiles.cairo 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   65.73%   64.02%   -1.71%     
==========================================
  Files          50       50              
  Lines        8334     8543     +209     
==========================================
- Hits         5478     5470       -8     
- Misses       2856     3073     +217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat merged commit de5b7d8 into main Jul 5, 2024
6 of 8 checks passed
@enitrat enitrat deleted the feat/whitelist-kakarot-reentrancy branch July 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants