Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: felt to bytes little underconstrained #1317

Merged

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Jul 31, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1300

What is the new behavior?


This change is Reviewable

@obatirou obatirou force-pushed the oba/felt-to-bit-little-underconstrained branch from 90435e9 to 8741986 Compare July 31, 2024 10:40
src/utils/bytes.cairo Outdated Show resolved Hide resolved
@obatirou obatirou force-pushed the oba/felt-to-bit-little-underconstrained branch from 8741986 to c574606 Compare August 1, 2024 10:54
@obatirou obatirou changed the title bug: felt to bit little underconstrained bug: felt to bytes little underconstrained Aug 1, 2024
@obatirou obatirou force-pushed the oba/felt-to-bit-little-underconstrained branch from 425fac7 to 2701ee2 Compare August 1, 2024 13:24
@obatirou obatirou marked this pull request as ready for review August 1, 2024 13:40
src/utils/bytes.cairo Show resolved Hide resolved
src/utils/bytes.cairo Outdated Show resolved Hide resolved
tests/src/utils/test_bytes.py Show resolved Hide resolved
enitrat
enitrat previously approved these changes Aug 1, 2024
@obatirou obatirou merged commit dbaac6c into kkrt-labs:main Aug 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: felt_to_bytes_little is underconstrained
2 participants