-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opti: charge_gas #1323
opti: charge_gas #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm under the assumption that gas_left < RC_BOUND
Let's wait to close #1329 before merging this one then |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
- Coverage 67.82% 64.36% -3.47%
==========================================
Files 46 50 +4
Lines 6983 8676 +1693
==========================================
+ Hits 4736 5584 +848
- Misses 2247 3092 +845 ☔ View full report in Codecov by Sentry. |
e94d56a
to
6f7e109
Compare
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
c3bec0a
to
ab9be1a
Compare
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1261
What is the new behavior?
Fix async tests
Tests using
get_contract
were skipped in local and CI due to not being able to run this function asget_solidity_contract
was not awaited andget_contract
not marked as async. With those changes, they now run in local and CI. They are using a sync version ofget_contract
.chage_gas consume less step
A gain of 9.5%
Test run:
poetry run pytest tests/src/kakarot -k test_loop_profiling\[10] --profile-cairo
Before: 156433
After with inlining: 141777
This change is