Fix underconstrained segments #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
force-pushed
the
cw/underconstrained-segments
branch
from
4c06f03
to
ca0864e
Compare
obatirou
reviewed
Aug 22, 2024
obatirou
reviewed
Aug 22, 2024
obatirou
previously approved these changes
Aug 22, 2024
enitrat
previously approved these changes
Aug 22, 2024
ClementWalter
force-pushed
the
cw/underconstrained-segments
branch
from
ca0864e
to
e9555b3
Compare
ClementWalter
force-pushed
the
cw/underconstrained-segments
branch
from
e9555b3
to
d8c2400
Compare
obatirou
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Segments are not constrained enough, making it possible for a malicious prover to tweak tx data.
Resolves #1313
What is the new behavior?
Added more
assertto make sure that we don't read data beyonddata_len.This change is