Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove library_call from precompiles #1397

Merged

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Sep 6, 2024

Time spent on this PR: 0.1

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

This precompile is never used but bears a severe security risk as it allows potential attackers to update the state of Kakarot.

What is the new behavior?

Removed.


This change is Reviewable

@ClementWalter ClementWalter marked this pull request as draft September 7, 2024 08:11
@ClementWalter ClementWalter force-pushed the cw/remove-library-call-precompile branch from 94c0002 to e7419ba Compare September 9, 2024 15:28
@ClementWalter ClementWalter marked this pull request as ready for review September 9, 2024 15:29
enitrat
enitrat previously approved these changes Sep 9, 2024
obatirou
obatirou previously approved these changes Sep 9, 2024
@ClementWalter ClementWalter dismissed stale reviews from obatirou and enitrat via 8c2fb05 September 9, 2024 16:22
@ClementWalter ClementWalter merged commit a0cd7fc into kkrt-labs:main Sep 9, 2024
4 checks passed
@ClementWalter ClementWalter deleted the cw/remove-library-call-precompile branch September 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants