Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): avoid relinking on makefile #1412

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

antiyro
Copy link
Contributor

@antiyro antiyro commented Sep 13, 2024

Key Modifications:

  1. Avoid Always Running clean in build: Removed $(MAKE) clean from build, so it won't delete and relink files every time.
  2. Timestamp Tracking for Artifacts:
    • The SSJ_DIR target only rebuilds if $(SSJ_ZIP) changes.
    • curl only runs if the zip file doesn't exist.
  3. Directory creation conditional: The build directory build/ssj is only recreated when necessary.

This change is Reviewable

@antiyro
Copy link
Contributor Author

antiyro commented Sep 13, 2024

This is a direct answer to @ClementWalter provocations!

ClementWalter
ClementWalter previously approved these changes Sep 13, 2024
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @antiyro

@enitrat enitrat merged commit a87ad27 into kkrt-labs:main Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants