Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix solidity version and enable optimizer #1425

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Sep 19, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1419

What is the new behavior?

  • fix solidity version for DualVMToken, L1/L2 KakarotMessaging contracts
  • enable optimizer
  • make sendMessageToL1 non payable to avoid locking ether

This change is Reviewable

@obatirou obatirou marked this pull request as ready for review September 19, 2024 10:25
@obatirou
Copy link
Collaborator Author

obatirou commented Sep 19, 2024

Optimizer make test_should_add_liquidity_and_swap failing: uniswap is compiled with foundry settings. This PR enable the optimizer hence change the bytecode of contract.
The init code hash needs to be updated to reflect the changes

Contracts are compiled with optimizer changing the bytecode
Hence the init code hash
@enitrat enitrat merged commit 221b976 into kkrt-labs:main Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: fix solidity version
2 participants