Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove 'compute_starknet_address' #1436

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 23, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • Remove this entrypoint, deprecated in favor of get_starknet_address

This change is Reviewable

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.9%. Comparing base (73356ca) to head (1eab764).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1436     +/-   ##
=======================================
- Coverage   62.9%   62.9%   -0.1%     
=======================================
  Files         49      49             
  Lines       8393    8386      -7     
=======================================
- Hits        5282    5275      -7     
  Misses      3111    3111             
Flag Coverage Δ
62.9% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit 87153b8 into main Sep 24, 2024
9 checks passed
@ClementWalter ClementWalter deleted the feat/remove-starknet-address branch September 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants