impl GASPRICE opcode (#97) #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.53% // Head: 87.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 87.53% 87.55% +0.02%
==========================================
Files 23 23
Lines 3545 3553 +8
==========================================
+ Hits 3103 3111 +8
Misses 442 442
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementWalter
previously approved these changes
Dec 16, 2022
| let calldata_len = self.call_context.calldata_len; | ||
| let count = Helpers.count_nonzeroes(nonzeroes=0, idx=0, arr_len=calldata_len, arr=calldata); | ||
| let zeroes = calldata_len - count.nonzeroes; | ||
| let calldata_cost = zeroes * 4 + count.nonzeroes * 16; |
There was a problem hiding this comment.
You could also factorize like
Cost = 4*len + 12*nonzeroes
ClementWalter
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #97
What is the new behavior?
ExecutionContext.intrinsic_gas_cost->ExecutionContext.gas_priceHelpers.count_nonzeroesthat returns the count of the nonzeroes of the calldata arrayConstants.TRANSACTION_INTRINSIC_GAS_COSTExecutionContext.compute_intrinsic_gas_costExecutionContext.increment_gas_usedand use the context returned from thatOther information