Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement stack pop_n #60

Merged
merged 4 commits into from
Oct 20, 2022
Merged

✨ Implement stack pop_n #60

merged 4 commits into from
Oct 20, 2022

Conversation

0xlny
Copy link
Contributor

@0xlny 0xlny commented Oct 19, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Pop N elements from the stack at once is now supported

@AbdelStark AbdelStark mentioned this pull request Oct 19, 2022
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful and good optimization. Thanks for this contribution.
LGTM

@@ -255,8 +255,11 @@ namespace ArithmeticOperations {
// Stack input:
// 0 - a: first integer value to add.
// 1 - b: second integer value to add.
let (stack, a) = Stack.pop(stack);
let (stack, b) = Stack.pop(stack);
// let (stack, a) = Stack.pop(stack);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

This was referenced Oct 19, 2022
@0xLucqs
Copy link
Contributor

0xLucqs commented Oct 20, 2022

Can you rebase on main please

@0xlny 0xlny merged commit 170e316 into main Oct 20, 2022
@0xlny 0xlny deleted the stack/pop_n branch October 20, 2022 13:05
0xLucqs added a commit that referenced this pull request Oct 20, 2022
@0xLucqs 0xLucqs restored the stack/pop_n branch October 20, 2022 13:22
This was referenced Oct 20, 2022
0xLucqs added a commit that referenced this pull request Oct 20, 2022
This was referenced Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants