Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement stack pop_n #77

Merged
merged 6 commits into from
Oct 21, 2022
Merged

✨ Implement stack pop_n #77

merged 6 commits into from
Oct 21, 2022

Conversation

0xlny
Copy link
Contributor

@0xlny 0xlny commented Oct 20, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Pop N elements from the stack at once is now supported

0xLucqs
0xLucqs suggested changes Oct 20, 2022
View reviewed changes
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
src/kakarot/instructions/arithmetic_operations.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
tests/units/kakarot/test_stack.cairo Outdated Show resolved Hide resolved
tests/units/kakarot/test_stack.cairo Outdated Show resolved Hide resolved
src/kakarot/stack.cairo Outdated Show resolved Hide resolved
@0xLucqs
Copy link
Contributor

0xLucqs commented Oct 21, 2022 •
edited
Loading

lgtm

@0xLucqs 0xLucqs self-requested a review October 21, 2022 08:37
@0xlny 0xlny merged commit ce5c178 into main Oct 21, 2022
@0xlny 0xlny deleted the stack/pop_n branch October 21, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xlny @0xLucqs