Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler (aka the centralized arbitrator) - Contract only #1517

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Feb 20, 2024

PR-Codex overview

This PR introduces changes to the DisputeResolver and DisputeResolverRuler contracts, adding functionality for creating and managing disputes in an arbitration system.

Detailed summary

  • Added virtual modifier to _createDispute function in DisputeResolver.
  • Created DisputeResolverRuler inheriting from DisputeResolver.
  • Implemented dispute creation and ruling modes in DisputeResolverRuler.
  • Added tests for dispute creation and ruling execution in ruler.ts.
  • Updated deployment script for arbitration contracts.

The following files were skipped due to too many changes: contracts/src/arbitration/devtools/KlerosCoreRuler.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jaybuidl jaybuidl marked this pull request as draft February 20, 2024 03:08
@github-actions github-actions bot added the Type: Epic 🐉 A large user story that can be broken down into a number of smaller stories. label Feb 20, 2024
Base automatically changed from feat/university to dev February 22, 2024 19:05
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 68e1048
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65e77e2162cc1000087addb8
😎 Deploy Preview https://deploy-preview-1517--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaybuidl jaybuidl changed the title Ruler (aka the centralized arbitrator) Ruler (aka the centralized arbitrator) - Contract only Mar 5, 2024
Copy link

codeclimate bot commented Mar 5, 2024

Code Climate has analyzed commit 68e1048 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 10
Style 1

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@jaybuidl jaybuidl marked this pull request as ready for review March 5, 2024 20:20
@jaybuidl jaybuidl enabled auto-merge March 5, 2024 20:20
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for kleros-v2-university ready!

Name Link
🔨 Latest commit 68e1048
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/65e77e21d6320d00087a1779
😎 Deploy Preview https://deploy-preview-1517--kleros-v2-university.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Contracts Court smart contracts Type: Epic 🐉 A large user story that can be broken down into a number of smaller stories. Type: Feature🗿
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruler Contracts (dev tool)
1 participant