Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy upload to Filebase/IPFS #639

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Policy upload to Filebase/IPFS #639

wants to merge 10 commits into from

Conversation

Params10
Copy link
Contributor

@netlify
Copy link

netlify bot commented Mar 18, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 3f8ad18
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/648a35dffca6c20007d7efb3
😎 Deploy Preview https://deploy-preview-639--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alcercu
alcercu requested changes Mar 20, 2023
View reviewed changes
contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
contracts/scripts/policyUpdate.ts Outdated
}
const json = JSON.parse(jsonString);
courtsV1 = json.map((courtDetails) => ({
...courtDetails,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the format of courtDetails? If you are destructuring it there is no need to repeat

name: courtDetails.name

as it will already be assigned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed extra step of destructuring.

contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
contracts/scripts/policyUpdate.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit 1bc7176 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 6
Style 4

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl changed the title Feat(script)/policy ipfs script Policy upload to Filebase/IPFS Jun 14, 2023
@jaybuidl jaybuidl added the Package: Contracts Court smart contracts label Jun 14, 2023
@jaybuidl jaybuidl mentioned this pull request Jun 14, 2023
Closed
@jaybuidl jaybuidl linked an issue Jun 14, 2023 that may be closed by this pull request
Script for ad-hoc court policy update with Filebase #590
Open
@jaybuidl jaybuidl force-pushed the feat(script)/policy-ipfs-script branch from 8409ab7 to 8ea2709 Compare June 14, 2023 21:15
@netlify
Copy link

netlify bot commented Jun 14, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 3f8ad18
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/648a35df6099fd00084fdec6
😎 Deploy Preview https://deploy-preview-639--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaybuidl jaybuidl force-pushed the feat(script)/policy-ipfs-script branch from 8ea2709 to 3f8ad18 Compare June 14, 2023 21:49
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu requested changes

@jaybuidl jaybuidl Awaiting requested review from jaybuidl

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Package: Backend Storage Package: Contracts Court smart contracts Package: Web Court web frontend Type: Enhancement ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script for ad-hoc court policy update with Filebase
3 participants
@Params10 @alcercu @jaybuidl