Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove old CoC info + update reporting info for CoC violations #1016

Merged
merged 2 commits into from
May 3, 2022

Conversation

lance
Copy link
Member

@lance lance commented Apr 19, 2022

  • 🧹 removes outdated Code of Conduct information from README.md
  • 🎁 adds reporting information to the bare CoC document, with Steering Committee as first line of defense

Fixes: #968 (comment)

@rhuss PTAL does this need to be added/updated to all repos in the org and in knative-sandbox?

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2022
@vaikas
Copy link
Contributor

vaikas commented Apr 19, 2022

I see the link to COC has been updated, so this LGTM. Just adding a hold so others can chime in just in case they have concerns (remove at will if there are none).
/lgtm
/approve
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@lance
Copy link
Member Author

lance commented Apr 19, 2022

@vaikas what I'm really curious about, though, is whether we will continue to use the code-of-conduct@knative.team email address to handle reporting, as it used to be documented here:

## Enforcement
Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by emailing code-of-conduct@knative.team. All complaints will be reviewed and
investigated and will result in a response that is deemed necessary and
appropriate to the circumstances. The project team is obligated to maintain
confidentiality with regard to the reporter of an incident. Further details of
specific enforcement policies may be posted separately.
TOC members who do not follow or enforce the Code of Conduct in good faith may
face temporary or permanent repercussions as determined by other members of the
project's leadership.

#968 is obsolete/irrelevant if all CoC violations go through the CNCF reporting structure. But I think it's perhaps better to restore some of the old enforcement text in our CoC, so that the first line of defense is Knative SC, but if that's insufficient or sensitive, issues can be elevated to CNCF enforcement. WDYT?

@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2022

Yeah, understood :) I went to look for what it says earlier and noticed it's a redirect, and indeed it's a pointer to the CNCF documentation. I don't see a point in having a separate email for reporting to Knative ones if we point to CNCF that has it's own set of reporting instructions?

For other projects, please contact the CNCF staff via [conduct@cncf.io](mailto:conduct@cncf.io). You can expect a response within three business days.

It explicitly lists kubernetes as it's own project, but I don't see any others. Are there other projects that handle their own COC despite being in the CNCF?

I think since we're adhering to CNCF COC, then having them (assuming they are willing to do it) sounds like it would be probably holistically a more consistent way to handle this across the whole CNCF eco system?

@lance
Copy link
Member Author

lance commented Apr 20, 2022

I took a look at buildpacks/pack to see what they are doing and they are doing their own thing entirely (which I find odd). https://github.com/buildpacks/.github/blob/main/CODE_OF_CONDUCT.md

@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2022

Unless there's a really good reason that I don't understand which is entirely possible, I'd rather have us adhere and use the existing processes for dealing with violations. Seems simpler, more consistent, and don't have to worry about things diverging.

@lance
Copy link
Member Author

lance commented Apr 20, 2022

Unless there's a really good reason that I don't understand which is entirely possible, I'd rather have us adhere and use the existing processes for dealing with violations. Seems simpler, more consistent, and don't have to worry about things diverging.

I'm OK with that. Maybe we can formalize that decision at the SC call tomorrow and then I will close this.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2022
@lance lance changed the title docs: remove old CoC info from README.md docs: remove old CoC info + update reporting info for CoC violations May 2, 2022
@lance lance requested a review from rhuss May 2, 2022 19:32
@lance
Copy link
Member Author

lance commented May 2, 2022

@vaikas updated per our latest understanding

@vaikas
Copy link
Contributor

vaikas commented May 2, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2022
@knative-prow
Copy link

knative-prow bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor

vaikas commented May 3, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2022
@knative-prow knative-prow bot merged commit e642b23 into knative:main May 3, 2022
@vaikas
Copy link
Contributor

vaikas commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROCESS CHANGE: CoC violations reporting and enforcement improvements/clarifications
2 participants