Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add document outlining the automation bots #1079

Merged
merged 4 commits into from
Jun 3, 2022
Merged

docs: add document outlining the automation bots #1079

merged 4 commits into from
Jun 3, 2022

Conversation

lance
Copy link
Member

@lance lance commented May 31, 2022 •
edited
Loading

Also provides documentation for CNCF during our transition to EasyCLA.

📖 adds some user documentation describing the current automation bots.

Question: Do we need to keep Knative Metrics Bot and Knative Prow Releaser Robot? These both have no recent activity.

Signed-off-by: Lance Ball lball@redhat.com

@lance
docs: add document outlining the automation bots
35efcae 
Also provides documentation for CNCF during our transition to EasyCLA.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow
Copy link

knative-prow bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2022
@lance
fixup: tyop
e90fffe 
Signed-off-by: Lance Ball <lball@redhat.com>
@upodroid
Copy link
Member

upodroid commented Jun 1, 2022

+1 to getting rid of unused bot accounts. The rest of the details look good to me.

@lance
fixup: now I know what prow-releaser-robot does
4020c6f 
Signed-off-by: Lance Ball <lball@redhat.com>
chizhg
chizhg reviewed Jun 1, 2022
View reviewed changes
peribolos/bots.md Outdated Show resolved Hide resolved
peribolos/bots.md Show resolved Hide resolved
@lance
Copy link
Member Author

lance commented Jun 1, 2022

+1 to getting rid of unused bot accounts. The rest of the details look good to me.

I see now that today is release day @knative-prow-releaser-robot is actually active. Still not sure about @knative-metrics-robot though

@chizhg
Copy link
Member

chizhg commented Jun 1, 2022

+1 to getting rid of unused bot accounts. The rest of the details look good to me.

I see now that today is release day @knative-prow-releaser-robot is actually active. Still not sure about @knative-metrics-robot though

I'm pretty sure @knative-metrics-robot is not in use now. Likely we only created this bot account but never used it.

evankanderson
evankanderson reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found my way here based on a mention of EasyCLA and bots, so I commented only on the EasyCLA aspects.

I think documenting these makes a lot of sense.

/lgtm

peribolos/bots.md Show resolved Hide resolved
peribolos/bots.md Show resolved Hide resolved
peribolos/bots.md Outdated Show resolved Hide resolved
peribolos/bots.md Outdated Show resolved Hide resolved
peribolos/bots.md Show resolved Hide resolved
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@chizhg
Copy link
Member

chizhg commented Jun 1, 2022

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2022
@chizhg
Copy link
Member

chizhg commented Jun 1, 2022 •
edited
Loading

Seems like there are open comments that are better to be addressed before merging.

@lance
fixup: incorporate PR feedback
89c26a4 
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@lance
Copy link
Member Author

lance commented Jun 2, 2022

I'm pretty sure @knative-metrics-robot is not in use now. Likely we only created this bot account but never used it.

I am going to leave it in the PR for now. Removal of the bot (and this description) can follow in another PR.

@lance
Copy link
Member Author

lance commented Jun 2, 2022

@chizhg @evankanderson updated based on some of your feedback. PTAL

evankanderson
evankanderson reviewed Jun 2, 2022
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@lance
Copy link
Member Author

lance commented Jun 3, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@knative-prow knative-prow bot merged commit dce37e8 into knative:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@chizhg chizhg chizhg left review comments

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance @upodroid @chizhg @evankanderson