Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add chzhyang to knative-snadbox/kperf approvers #1275

Merged
merged 2 commits into from
Feb 14, 2023
Merged

re-add chzhyang to knative-snadbox/kperf approvers #1275

merged 2 commits into from
Feb 14, 2023

Conversation

chzhyang
Copy link
Contributor

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2023
@psschwei
Copy link
Contributor

You need to run ./hack/update-codegen.sh

@chzhyang
Copy link
Contributor Author

You need to run ./hack/update-codegen.sh

Thank you, addressed it, please review again.

psschwei
psschwei reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chzhyang, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@knative-prow knative-prow bot merged commit 297de07 into knative:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chzhyang @psschwei