Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow release leads to submit jobs to prow via kubectl #1287

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

upodroid
Copy link
Member

/cc @kvmware

@knative-prow knative-prow bot requested a review from krsna-m February 21, 2023 16:51
@knative-prow
Copy link

knative-prow bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Feb 21, 2023

/lgtm
THANKS!!!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Feb 21, 2023

Can we add the release leads group there too?

@knative-prow knative-prow bot merged commit f9429bb into main Feb 21, 2023
@dprotaso dprotaso deleted the release-leads-gke-rbac branch May 23, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants