-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 New Repo: knative/toolbox
#1293
Conversation
+1 Might want to tweak the name to imply these tools are for the infrastructure plumbing. Or make it very clear in the README.md that we maintain these just for Knative. |
+1 for making it more obvious, |
Those tools are not only for infrastructure. We plan to have tools for development tasks as well, like: codegen, update-deps, testing etc. Those tools will be used in Knative, but they may be useful in other projects as well. |
@evankanderson @dprotaso @zroubalik @dsimansk Regarding yesterday's TOC meeting, and this comment #1291 (comment), I think we can go ahead and merge this PR, right? |
Agreed on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOC agreed on toolbox on March 9
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
knative/toolbox
repo/kind enhancement
Fixes #1291