Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 New Repo: knative/toolbox #1293

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Feb 23, 2023

Changes

  • 🎁 Creation of knative/toolbox repo

/kind enhancement

Fixes #1291

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2023
@cardil cardil changed the title 🎁 Creation of knative/tools repo 🎁 New Repo: knative/tools Feb 23, 2023
@cardil cardil mentioned this pull request Feb 23, 2023
14 tasks
@dprotaso
Copy link
Member

+1

Might want to tweak the name to imply these tools are for the infrastructure plumbing. Or make it very clear in the README.md that we maintain these just for Knative.

@zroubalik
Copy link
Contributor

+1

Might want to tweak the name to imply these tools are for the infrastructure plumbing. Or make it very clear in the README.md that we maintain these just for Knative.

+1 for making it more obvious, infra-tools ?

@cardil
Copy link
Contributor Author

cardil commented Feb 28, 2023

Might want to tweak the name to imply these tools are for the infrastructure plumbing. Or make it very clear in the README.md that we maintain these just for Knative.

Those tools are not only for infrastructure. We plan to have tools for development tasks as well, like: codegen, update-deps, testing etc.

Those tools will be used in Knative, but they may be useful in other projects as well.

peribolos/knative.yaml Outdated Show resolved Hide resolved
@cardil
Copy link
Contributor Author

cardil commented Mar 3, 2023

@evankanderson @dprotaso @zroubalik @dsimansk Regarding yesterday's TOC meeting, and this comment #1291 (comment), I think we can go ahead and merge this PR, right?

@evankanderson
Copy link
Member

Agreed on toolbox as the name for the repo, ping me and I will approve when the name changes

@cardil cardil changed the title 🎁 New Repo: knative/tools 🎁 New Repo: knative/toolbox Mar 10, 2023
@cardil cardil requested review from dsimansk and removed request for dprotaso and evankanderson March 10, 2023 09:22
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOC agreed on toolbox on March 9
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@knative-prow knative-prow bot merged commit 0245729 into knative:main Mar 10, 2023
@cardil cardil deleted the feature/knative-tools-repo branch March 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create repo: knative/toolbox
6 participants