Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds knative-sandbox/func-tastic repo to peribolos #969

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Adds knative-sandbox/func-tastic repo to peribolos #969

merged 2 commits into from
Mar 22, 2022

Conversation

lance
Copy link
Member

@lance lance commented Mar 16, 2022

Signed-off-by: Lance Ball lball@redhat.com

See: #935

@lance lance requested a review from a team March 16, 2022 17:06
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2022
@lance
Copy link
Member Author

lance commented Mar 16, 2022

Seems like a chicken/egg problem on the unsuccessful check.

@rhuss
Copy link
Contributor

rhuss commented Mar 17, 2022

/retest

@rhuss
Copy link
Contributor

rhuss commented Mar 21, 2022

@lance you need to run hack/update-codegen.sh to regenerated the OWNERS files, otherwise it looks good. Could be that I need to add the approver team manually when a test fails.

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2022
@lance
Adds knative-sandbox/func-tastic repo to peribolos
b59c361 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
fixup: run ./hack/update-codegen.sh
259e7d2 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance force-pushed the lance/935-add-func-tastic branch from 30df1c4 to 259e7d2 Compare March 21, 2022 18:12
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
@lance
Copy link
Member Author

lance commented Mar 21, 2022

/retest

@lance
Copy link
Member Author

lance commented Mar 22, 2022

Apparently I have chanted the black magic phrases incorrectly. Really... just want to create a repo! 😄 I'm not sure what to do next to make that happen.

@rhuss
Copy link
Contributor

rhuss commented Mar 22, 2022

/retest

@rhuss
Copy link
Contributor

rhuss commented Mar 22, 2022

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
@knative-prow-robot knative-prow-robot merged commit 8dc75d4 into knative:main Mar 22, 2022
@evankanderson
Copy link
Member

(lance is an approver as part of Steering)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance @rhuss @knative-prow-robot @evankanderson