Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates queue container to support h2c #1257

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Updates queue container to support h2c #1257

merged 1 commit into from
Jun 18, 2018

Conversation

bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Jun 18, 2018

Pre-req: #707, #813

Follow up from #987

Proposed Changes

  • switches to using an h2(c) server (non TLS) in the queue container

Release Note

NONE

@google-prow-robot google-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2018
@google-prow-robot google-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2018
@bsnchan
Copy link
Contributor Author

bsnchan commented Jun 18, 2018

/test pull-knative-serving-integration-tests

Tests seem to have failed fetching the project name.

@bsnchan
Copy link
Contributor Author

bsnchan commented Jun 18, 2018

/assign @evankanderson

@bsnchan bsnchan mentioned this pull request Jun 18, 2018
Closed
3 tasks
evankanderson
evankanderson approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsnchan, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2018
@google-prow-robot google-prow-robot merged commit e5f9680 into knative:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson approved these changes

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsnchan @google-prow-robot @evankanderson