Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple network prober to the activator. #3257

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add a simple network prober to the activator. #3257

merged 1 commit into from
Feb 22, 2019

Commits on Feb 22, 2019

  1. Add a simple network prober to the activator. 

    When the flag `-enable-network-probing` is passed (on by default) the activator will replace its retring transport logic with a simple network probe based on knative#3256 with a similar number of retries to what the retrying transport was previously configured to use.  Enabling this allows the GRPC test with streaming and cold-start fairly reliably on my cluster (and also with the GRPC ping sample in knative/docs, with my fixes).

This change also refactors the GRPC test into 4 tests, for each of the logical things tested, which will hopefully reduce the amount of time this adds to e2e dramatically when we switch to use `t.Parallel()` since it will parallelize the two times this waits for a scale-to-zero.

Fixes: knative#3239
Fixes: knative#2856
    @mattmoor
    mattmoor committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    b5dbff6 View commit details
    Browse the repository at this point in the history