Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports gRPC as a protocol (without TLS) #987

Closed
wants to merge 17 commits into from
Closed

Supports gRPC as a protocol (without TLS) #987

wants to merge 17 commits into from

Commits on Jun 18, 2018

  1. Supports gRPC as a protocol (without TLS) 

    * TODO: activator support, e2e tests,
        switching to using an h2c server (non TLS)t in ela-queue

knative/serving#707
knative/serving#813

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
    @bsnchan @dprotaso
    bsnchan and dprotaso committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d7254f9 View commit details
    Browse the repository at this point in the history

  2. Modifies ela-queue to use a h2c server 

    * The h2c server can proxy both h2c and http requests based on the
request's protocol

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
    @bsnchan @dprotaso
    bsnchan and dprotaso committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    51b5627 View commit details
    Browse the repository at this point in the history

  3. Update the activator to use an h2c server 

    * We needed to create an activator service per protocol
  Since services cannot share a port with different protocols

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
    @bsnchan @dprotaso
    bsnchan and dprotaso committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    92123eb View commit details
    Browse the repository at this point in the history

  4. Update grpc-ping sample 

    Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
    @bsnchan @dprotaso
    bsnchan and dprotaso committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    962b768 View commit details
    Browse the repository at this point in the history

  5. Refactors sample grpc-ping app

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    b2bb3aa View commit details
    Browse the repository at this point in the history

  6. Adds e2e test for gRPC application

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    1f64ec3 View commit details
    Browse the repository at this point in the history

  7. Rebasing changes after knative renaming

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    07bab67 View commit details
    Browse the repository at this point in the history

  8. Bump Request Timeout to 90s for e2e tests 

    * When the Ingress is updated for gRPC, the service takes some time to
mark the upstream as healthy
    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    f6456c0 View commit details
    Browse the repository at this point in the history

  9. Bump timeout to 2 minutes because the tests are flakey

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    96b4fe1 View commit details
    Browse the repository at this point in the history

  10. Updates tests with new ingress name

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    8c8a7cc View commit details
    Browse the repository at this point in the history

  11. More rebasing changes, Removes long timeout due to e2e flakiness

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    fa6ddee View commit details
    Browse the repository at this point in the history

  12. Removes vendored grpc-go dependency 

    * it was only being used in the sample grpc app so we now pull in the
depency via the sample app's dockerfile

* also removed unused variables from cmd/queue/main.go
    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c875b4c View commit details
    Browse the repository at this point in the history

  13. Moves h2c package to third_party folder

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c001fd7 View commit details
    Browse the repository at this point in the history

  14. Prepend grpc related sample apps with '_' so go build and go tests 

    ignore the folders

* google.golang.org/grpc is not vendored in since it is only used in the sample
apps so don't attempt to build or test the sample grpc apps
    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    0301aa5 View commit details
    Browse the repository at this point in the history

  15. Removes grpc e2e test

    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    678c753 View commit details
    Browse the repository at this point in the history

  16. Label grpc-ping with a build tag 

    * This is allows go build ./sample/... to run successfully since the grpc
dependencies are not vendored in
    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    0864f31 View commit details
    Browse the repository at this point in the history

  17. Changes based on suggestions 

    * removes golang/protobuf from Gopkg.toml
* alias h2c package as h2cutil
* adds a comment for NewTransport
* removes refactoring changes (will submit them as a separate pr)
* updates sample app's readme to use buildtag when running client code
    @bsnchan
    bsnchan committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    8a4e384 View commit details
    Browse the repository at this point in the history