Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing file.Close() for bdb and ndb #43

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add missing file.Close() for bdb and ndb #43

merged 2 commits into from
Sep 12, 2023

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Sep 8, 2023

Fixes pkg/ndb and pkg/bdb packages which do not close their underlying file.

@knqyf263
Copy link
Owner

knqyf263 commented Sep 8, 2023

Thanks for pointing out that. I think we should add Close() to BerkeleyDB and RpmNDB, and ask the caller to close it.

@jinroh
Copy link
Contributor Author

jinroh commented Sep 11, 2023

Sure. Added the Close() method on RpmDBInterface and RpmDB wrapper; up to the caller to close it.

@knqyf263 knqyf263 merged commit bd1c2e6 into knqyf263:master Sep 12, 2023
1 check passed
@knqyf263
Copy link
Owner

Thanks!

@jinroh jinroh deleted the leaked-fds branch September 12, 2023 08:16
@testwill testwill mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinroh @knqyf263