-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildvcs=false must be added to a default build args #672
Comments
It might make sense to add a |
Better add something like |
I had to look this up myself. It looks like |
… builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - #2508 (comment) , - ko-build/ko#672 - golang/go#49004
… builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - #2508 (comment) , - ko-build/ko#672 - golang/go#49004
* deployment/docker: pass `-buildvs=false` to `go build` for production builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - #2508 (comment) , - ko-build/ko#672 - golang/go#49004 * lib/netutil: limit the number of concurrently established connections when calling ConnPool.Get() This should reduce potential spikes in the number of established connections in the following cases: - when the connection establishing procedure becomes temporarily slow - after a temporary spike in the rate of ConnPool.Get() calls See #2552 * docs/CHANGELOG.md: document c8af625 See #1322 (comment) * docs/Cluster-VictoriaMetrics.md: typo fix: `by by` -> `by` * docs: add `resource usage limits` docs, which describe fine-grained tuning for various resource usage limits * docs/Cluster-VictoriaMetrics.md: the `/api/v1/label/.../values` query can take CPU and ram at both vmstorage and vmselect * Update root Readme and root vmagent readme Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
* deployment/docker: pass `-buildvs=false` to `go build` for production builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - #2508 (comment) , - ko-build/ko#672 - golang/go#49004 * lib/netutil: limit the number of concurrently established connections when calling ConnPool.Get() This should reduce potential spikes in the number of established connections in the following cases: - when the connection establishing procedure becomes temporarily slow - after a temporary spike in the rate of ConnPool.Get() calls See #2552 * docs/CHANGELOG.md: document c8af625 See #1322 (comment) * docs/Cluster-VictoriaMetrics.md: typo fix: `by by` -> `by` * docs: add `resource usage limits` docs, which describe fine-grained tuning for various resource usage limits * docs/Cluster-VictoriaMetrics.md: the `/api/v1/label/.../values` query can take CPU and ram at both vmstorage and vmselect * Update root Readme and root vmagent readme Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
… builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - VictoriaMetrics#2508 (comment) , - ko-build/ko#672 - golang/go#49004
* deployment/docker: pass `-buildvs=false` to `go build` for production builds This should resolve the `error obtaining VCS status: exit status 128` error when the environment contains incorrect version of git or has incorrect access rights to the directory with VictoriaMetrics source code. See the following links for additional info: - VictoriaMetrics#2508 (comment) , - ko-build/ko#672 - golang/go#49004 * lib/netutil: limit the number of concurrently established connections when calling ConnPool.Get() This should reduce potential spikes in the number of established connections in the following cases: - when the connection establishing procedure becomes temporarily slow - after a temporary spike in the rate of ConnPool.Get() calls See VictoriaMetrics#2552 * docs/CHANGELOG.md: document c8af625 See VictoriaMetrics#1322 (comment) * docs/Cluster-VictoriaMetrics.md: typo fix: `by by` -> `by` * docs: add `resource usage limits` docs, which describe fine-grained tuning for various resource usage limits * docs/Cluster-VictoriaMetrics.md: the `/api/v1/label/.../values` query can take CPU and ram at both vmstorage and vmselect * Update root Readme and root vmagent readme Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
This issue is stale because it has been open for 90 days with no |
see: ko-build/ko#672 It changed in go1.18 and is breaking CI for others too. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Since Go 1.18
It means, that go binary maybe changed without actual changes, and also means that building on CI machine is failed (since no Git in path).
Workaround: prepend ko command with
GOFLAGS="-buildvcs=false"
The text was updated successfully, but these errors were encountered: