Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --image-refs #555

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

mattmoor
Copy link
Collaborator

This change adds a new --image-refs=FILE flag that can be used to
direct ko to write a file containing a \n delimited list of published
references. In the common case, this will contain the list of digest
references, but if flags directing the use of tags are present this
will reflect the style of reference requested.

@mattmoor
Copy link
Collaborator Author

Pretty sure I need to update the CLI docs, so this will fail.

@mattmoor
Copy link
Collaborator Author

Ok, pushed an update with the codegen

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #555 (8150239) into main (8135bf2) will decrease coverage by 0.23%.
The diff coverage is 26.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   48.82%   48.58%   -0.24%     
==========================================
  Files          42       43       +1     
  Lines        2204     2229      +25     
==========================================
+ Hits         1076     1083       +7     
- Misses        946      959      +13     
- Partials      182      187       +5     
Impacted Files Coverage Δ
pkg/commands/options/publish.go 40.54% <0.00%> (-2.32%) ⬇️
pkg/commands/resolver.go 30.37% <0.00%> (-1.18%) ⬇️
pkg/publish/recorder.go 46.66% <46.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8135bf2...8150239. Read the comment docs.

This change adds a new `--image-refs=FILE` flag that can be used to
direct `ko` to write a file containing a `\n` delimited list of published
references.  In the common case, this will contain the list of digest
references, but if flags directing the use of tags are present this
will reflect the style of reference requested.
pkg/publish/recorder_test.go Outdated Show resolved Hide resolved
pkg/publish/recorder.go Show resolved Hide resolved
pkg/publish/recorder_test.go Outdated Show resolved Hide resolved
pkg/publish/recorder.go Outdated Show resolved Hide resolved
@mattmoor
Copy link
Collaborator Author

Fixed the couple little things, good eyes. 🙏

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'd like Jon to weigh in before merging.

@jonjohnsonjr jonjohnsonjr merged commit f5762be into ko-build:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants