Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial platform matching for osversion only #572

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

imjasonh
Copy link
Member

Also move platform filtering into one location in pkg/build/gobuild.go. If only one child image matches, fallback to building a single-platform image; otherwise, build a (possibly filtered) multi-platform index.

A lot of this code will benefit from platform (de-)stringification improving inside ggcr, which I'll send out shortly.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #572 (e6211d0) into main (70b671c) will decrease coverage by 0.16%.
The diff coverage is 59.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   48.70%   48.53%   -0.17%     
==========================================
  Files          43       43              
  Lines        2234     2215      -19     
==========================================
- Hits         1088     1075      -13     
+ Misses        959      954       -5     
+ Partials      187      186       -1     
Impacted Files Coverage Δ
pkg/commands/config.go 54.54% <33.33%> (-3.04%) ⬇️
pkg/build/gobuild.go 57.25% <62.06%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b671c...e6211d0. Read the comment docs.

jonjohnsonjr
jonjohnsonjr previously approved these changes Jan 27, 2022
@imjasonh imjasonh merged commit 5f733f9 into ko-build:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants