-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning users when using both --base-import-paths --bare flags #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for doing this! Just a few tiny style/naming things, but otherwise 👍
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
thanks @imjasonh for the quick review and feedback, I've addressed your comments PTAL when have some free cycle |
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 50.72% 50.40% -0.32%
==========================================
Files 43 44 +1
Lines 3316 3337 +21
==========================================
Hits 1682 1682
- Misses 1424 1445 +21
Partials 210 210
Continue to review full report at Codecov.
|
Signed-off-by: cpanato <ctadeu@gmail.com>
@imjasonh fixed the header ready to go |
warning users when using both --base-import-paths --bare flags
Partially fixes #542
@imjasonh let me know if this is something you have in mind, otherwise, if this is not the project want we can close or improve. thanks!