Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ko.local and kind.local detection to include sub-repos #796

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Extend ko.local and kind.local detection to include sub-repos #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Extend ko.local and kind.local detection to include sub-repos
  • Loading branch information
@imjasonh
imjasonh committed Aug 22, 2022
commit 3c96e97565af8a3bf0b1c6d825bb66423c115d6d
4 changes: 2 additions & 2 deletions pkg/commands/resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func makePublisher(po *options.PublishOptions) (publish.Interface, error) {
innerPublisher, err := func() (publish.Interface, error) {
repoName := po.DockerRepo
namer := options.MakeNamer(po)
if repoName == publish.LocalDomain || po.Local {
if strings.HasPrefix(repoName, publish.LocalDomain) || po.Local {
// TODO(jonjohnsonjr): I'm assuming that nobody will
// use local with other publishers, but that might
// not be true.
Expand All @@ -177,7 +177,7 @@ func makePublisher(po *options.PublishOptions) (publish.Interface, error) {
publish.WithLocalDomain(po.LocalDomain),
)
}
if repoName == publish.KindDomain {
if strings.HasPrefix(repoName, publish.KindDomain) {
return publish.NewKindPublisher(namer, po.Tags), nil
}

Expand Down