tools: remove --fix to catch lint errors #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the test failed? |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 5 5
Lines 369 369
=======================================
Hits 368 368
Misses 1 1Continue to review full report at Codecov.
|
dead-horse
approved these changes
Sep 19, 2017
khchine5
added a commit
to khchine5/koa
that referenced
this pull request
Sep 24, 2017
tools: remove --fix to catch lint errors (koajs#1062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
--fixalways runs, lint on travis does not non-zero exit unless it's "unfixable".