Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

in IE11 namespaced attributes from instance not merged into model #569

Closed
MartijnR opened this issue Oct 26, 2016 · 2 comments
Closed

in IE11 namespaced attributes from instance not merged into model #569

MartijnR opened this issue Oct 26, 2016 · 2 comments
Labels

Comments

@MartijnR
Copy link
Member

MartijnR commented Oct 26, 2016

Particularly critical for ordinal attributes. This bug means that ordinals are rebuilt from scratch.

So if you submit this:

<data>
    <repeat enk:last-used-ordinal="3" ordinal="1">
          <a>existing value</a>
    </repeat>
    <repeat ordinal="3">
          <a>another value</a>
    </repeat>
</data>

The model that is created looks like this:

<data>
    <repeat enk:last-used-ordinal="2" ordinal="1">
          <a>existing value</a>
    </repeat>
    <repeat ordinal="2">
          <a>another value</a>
    </repeat>
</data>

So this is CRITICAL because it means data is stored in the wrong db row (ordinal number) and ordinal 2 re-appears after having been deleted previously (and with the wrong data).

@MartijnR MartijnR added the bug label Oct 26, 2016
@MartijnR MartijnR added this to the OpenClinica Commitments milestone Oct 26, 2016
@MartijnR MartijnR added the OC label Oct 26, 2016
@MartijnR
Copy link
Member Author

MartijnR commented Oct 26, 2016

This is actually regression in mergexml 1.1.1 after all caused by my own PR to fix an earlier ordinal issue in IE11 for OC.

@MartijnR
Copy link
Member Author

hareko/js-merge-xml#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant