Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed namespaced attributes exception in IE11 (and below probably). #14

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

MartijnR
Copy link
Collaborator

@MartijnR MartijnR commented Oct 26, 2016

The exception is fixed, but namespaced attributes in IE (and below) are now added in the old incorrect way.

I think there is a way to properly add namespaced attributes to ActiveXObjects but that seemed rather cumbersome to find out. While Internet Explorer is still alive I'll just re-parse the .Get(1) XML string in my app (because IE11 does actually have a DOMParser). (Alternatively you could decide to let .Get(0) do this if GetMode() === 2 && typeof window.DOMParser !== 'undefined')

Also made tests more IE11 friendly as .Get(1) returns some additional whitespace in IE11.

Last PR for a while, I hope!

I took the liberty of changing the version to 1.1.2 as well.

@MartijnR
Copy link
Collaborator Author

closes #10 (except for IE)

@hareko hareko merged commit 085b079 into hareko:master Oct 27, 2016
@hareko
Copy link
Owner

hareko commented Oct 27, 2016

Thanks for the fix.

I'd not change the version again because the 1.1.1 updates concern the namespaced attributes too.

@MartijnR
Copy link
Collaborator Author

MartijnR commented Oct 27, 2016

Thanks. Better to publish as 1.1.2 on npm because now your latest npm-published version is completely non-functional in Internet Explorer!

The last version digit is for patches, so it's perfect to publish 1.1.2 for this reason. Npm requires a new package.json version to update the registry.

@MartijnR MartijnR deleted the fix/IE-namespaces-and-tests branch October 27, 2016 17:06
@MartijnR MartijnR restored the fix/IE-namespaces-and-tests branch October 27, 2016 17:06
@MartijnR MartijnR deleted the fix/IE-namespaces-and-tests branch October 27, 2016 17:06
@hareko
Copy link
Owner

hareko commented Oct 28, 2016

Ok, 1.1.2 is published.

@MartijnR
Copy link
Collaborator Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants