Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide disabled pagination buttons #1887

Closed
yangwao opened this issue Jan 17, 2022 · 1 comment · Fixed by #1892
Closed

Hide disabled pagination buttons #1887

yangwao opened this issue Jan 17, 2022 · 1 comment · Fixed by #1892
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app UX first Improvement for UX v2.2

Comments

@yangwao
Copy link
Member

yangwao commented Jan 17, 2022

Let's remove pagination buttons if they are disabled.

  • Collection detail
  • Artist tabs
  • where else?

https://kodadot.xyz/rmrk/u/EzZjBjv9bRPYJEbUdijzgjb9VMSqrqwx2eqnfjQcY5YvXCk?search=&listed=true

image

image
@yangwao yangwao added UX first Improvement for UX $ ~<50usd p2 core functionality, or is affecting 60% of app v2.2 labels Jan 17, 2022
@prachi00
Copy link
Member

@yangwao I'll do this

prachi00 added a commit to prachi00/nft-gallery that referenced this issue Jan 17, 2022
@prachi00
kodadot#1887 Hide disabled pagination buttons
d890a62
@prachi00 prachi00 mentioned this issue Jan 17, 2022
Closed
15 tasks
prachi00 added a commit to prachi00/nft-gallery that referenced this issue Jan 17, 2022
@prachi00
kodadot#1887 Hide disabled pagination buttons
8c9475f
@prachi00 prachi00 mentioned this issue Jan 17, 2022
Merged
15 tasks
yangwao added a commit that referenced this issue Jan 17, 2022
@yangwao
Merge pull request #1892 from prachi00/feat-pagination-hidden
2297518 
#1887 Hide disabled pagination buttons
This was referenced Jan 17, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app UX first Improvement for UX v2.2
Projects
None yet
Milestone
No milestone
2 participants
@yangwao @prachi00