Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current KSM price and link to extrinsic to Transfer dialog #675

Closed
yangwao opened this issue Sep 1, 2021 · 2 comments · Fixed by #692
Closed

Add current KSM price and link to extrinsic to Transfer dialog #675

yangwao opened this issue Sep 1, 2021 · 2 comments · Fixed by #692
Labels
$ ~<50usd good first issue as new commer, something you could start with p4 affecting less than 10% of app

Comments

@yangwao
Copy link
Member

yangwao commented Sep 1, 2021

  1. Display link for the transaction which was made on Subscan using generated extrinsic, i.e.
    0x256768b350ed980fd6dfb1d6172807be8765b04f475f3c315f5632bdd0417568 linking to
    https://kusama.subscan.io/extrinsic/0x256768b350ed980fd6dfb1d6172807be8765b04f475f3c315f5632bdd0417568

Somewhere permanent, no in snackbar, best if you can add there copy to clipboard button.

  1. Display somewhere current price of $KSM. You can find a way how we fetch prices from coingecko in kodadot.

image

For more check this PR how is Transfer made #672

@yangwao yangwao added good first issue as new commer, something you could start with p4 affecting less than 10% of app $ ~<50usd labels Sep 1, 2021
@yangwao yangwao changed the title Add coingecko price to Transfer dialog Add current KSM price and link to extrinsic to Transfer dialog Sep 3, 2021
@prachi00
Copy link
Member

prachi00 commented Sep 3, 2021

@yangwao is the transaction link suppose to show up here only that is /transfer route? Since I believe it will go away once you click on a different route and hence wont be permanent

@yangwao
Copy link
Member Author

yangwao commented Sep 3, 2021

@yangwao is the transaction link suppose to show up here only that is /transfer route? Since I believe it will go away once you click on a different route and hence wont be permanent

Yes, on transfer only, that would be more than enough I guess :)

yangwao added a commit that referenced this issue Sep 7, 2021
#675 Open ksm transaction and view current price of KSM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd good first issue as new commer, something you could start with p4 affecting less than 10% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants