feat: Make EVM wallet connector #10354

hassnian · 2024-05-27T11:50:37Z

PR Type

Bugfix
Feature
Refactoring

Context

❗️❗️ Needs WALLET_CONNECT_PROJECT_ID env

Closes Make EVM wallet connector #10284
Closes Temp fix: Hide elements in sidebar for EVM #10380
Closes Profile does not load on Base #10381

Needs QA check

@kodadot/qa-guild please review

Needs Design check

@exezbcz please review

Did your issue had any of the "$" label on it?

Fill up your DOT address: Payout

Screenshot 📸

My fix has changed something on UI;

netlify · 2024-05-27T11:50:56Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`9274610`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6661bac62e4b690008f1098a
😎 Deploy Preview	https://deploy-preview-10354--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

socket-security · 2024-05-27T11:51:36Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

🚮 Removed packages: npm/cross-env@7.0.3, npm/date-fns@2.30.0, npm/prettier@3.2.5, npm/prismjs@1.29.0, npm/typescript@5.4.5

View full report↗︎

codeclimate

The PR diff size of 5757 lines exceeds the maximum allowed for the inline comments feature.

…into issue-10284

codeclimate

The PR diff size of 5757 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5761 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5812 lines exceeds the maximum allowed for the inline comments feature.

…able

codeclimate

The PR diff size of 5850 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5850 lines exceeds the maximum allowed for the inline comments feature.

Jarsen136 · 2024-06-04T11:27:51Z

maintain wallet connected after merge context

adding in this in the developer console
localStorage.setItem('kodaauth', "1yHddTK4XihjK2DJE8g3oKV5d51TKPmnaCdYgPPTWqm6Ed4") 
localStorage.setItem('wallet', "talisman")
localStorage.setItem('walletname', "test")
and then refreshing the page should show the wallet as connected

keep this line could probably fixed the bug as it's related to old cache data.

prury · 2024-06-04T12:31:52Z

will do another round after comments

prury · 2024-06-04T22:24:33Z

works nicely on mobile as well(installed metamask for mobile and created an ethereum account)

can be solved here:

the removal of the links on the sidebar(transfer, teleport, etc) only works when you first log in, if you navigate trough the page it comes back
if i log into evm account and change networks, sidebar gets empty
base and immutable dissapear from chain list after i log in (to reproduce, log with evm acc and click on drops)

could be followup:

i recommend deactivating buying/transfer/mint,nft creation on other chains when the user is logged with evm account
will on ramp work if i use it on a evm account?

codeclimate

The PR diff size of 5847 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5872 lines exceeds the maximum allowed for the inline comments feature.

hassnian · 2024-06-05T05:17:01Z

keep this line could probably fixed the bug as it's related to old cache data

no need to keep that , the entire local storage gets cleared anyway after calling resetAuth()

hassnian · 2024-06-05T05:29:27Z

works nicely on mobile as well(installed metamask for mobile and created an ethereum account)

can be solved here:

the removal of the links on the sidebar(transfer, teleport, etc) only works when you first log in, if you navigate trough the page it comes back

I can't reproduce that , can you share a video ?

if i log into evm account and change networks, sidebar gets empty

only balance and bottom links are hidden as part of #10380

if you have NFTs in that account you would see them

base and immutable dissapear from chain list after i log in (to reproduce, log with evm acc and click on drops)

agreed with @exezbcz that once a wallet is selected you can only see chains that have the same vm as the connected wallet

could be followup:

i recommend deactivating buying/transfer/mint,nft creation on other chains when the user is logged with evm account

iirc @exezbcz said atm we should just hide other chains

will on ramp work if i use it on a evm account?

not atm because it will try to buy DOT , just checked and transak does supports eth on base and imx

base

imx

exezbcz · 2024-06-05T09:33:16Z

not atm because it will try to buy DOT , just checked and transak does supports eth on base and imx

skip onramp for now

exezbcz · 2024-06-06T09:05:29Z

what is missing to merge?

codeclimate

The PR diff size of 5870 lines exceeds the maximum allowed for the inline comments feature.

hassnian · 2024-06-06T09:54:29Z

what is missing to merge?

review comments are done, wating for @prury's approval context

codeclimate

The PR diff size of 5870 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5884 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-06-06T11:00:25Z

Code Climate has analyzed commit 9ba8184 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2024-06-06T13:34:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

hassnian · 2024-06-06T13:37:31Z

@vikiival merge conflicts solved

hassnian added 6 commits May 24, 2024 11:09

add(wallet): swicth wallet type

eabac40

ref(wallet): move ConnectWalletModal.vue

cc56933

add(wallet): initial web3 modal integration

092992e

fix(wallet): evm connecting and disconnecting properly

461c466

ref(ConnectWalletModal): cleanup

d07ba54

fix(wallet): filter current chains by selected wallet vm

fe7f7f7

fix: update missing pnpm lock

0d0d5f7

codeclimate bot reviewed May 27, 2024

View reviewed changes

hassnian and others added 4 commits May 27, 2024 17:50

fix(useChain.ts): remove duplicate koda static imports

588d619

fix: remove duplicate import

9f603d0

Merge branch 'main' into issue-10284

a1bc4a6

Merge branch 'issue-10284' of https://github.com/hassnian/nft-gallery …

f3ba80b

…into issue-10284

codeclimate bot reviewed May 27, 2024

View reviewed changes

hassnian added 5 commits May 27, 2024 18:31

ref(ConnectWalletModal.vue): change prefix on wallet connect

bd15fe9

fix(WalletConnectModal.vue): move MnemonicNotice to both vm

10abdd2

ref(wallet): add loading state while connecting evm wallet

caa7658

add(wallet): disconnecting state

77a9379

ref(wallet): remove circular watch

546a7c6

codeclimate bot reviewed May 28, 2024

View reviewed changes

hassnian added 4 commits May 28, 2024 12:18

ref(ChainSelectDropdown.vue): create useAvailableChainsOptions compos…

1c35b6f

…able

fix(useIdentity.ts): modal not openning imx

00c0c36

ref(identity.ts): remove kodaauth key

6ef8c08

ref(stores/wallet.ts): remove wallet-history seperate storage

60930c3

codeclimate bot reviewed May 28, 2024

View reviewed changes

Merge branch 'main' into issue-10284

156bba9

codeclimate bot reviewed May 28, 2024

View reviewed changes

ref(ConnectWallet): remove extra folder

a1192a7

prury removed the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 4, 2024

prury added S-changes-requested-🤞 PR is almost good to go, just some fine tunning and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 4, 2024

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 4, 2024

Merge branch 'main' into issue-10284

4caa5ea

codeclimate bot reviewed Jun 5, 2024

View reviewed changes

ref(fetchTabsCountByNetwrok): check also evm chains

3b986f9

codeclimate bot reviewed Jun 5, 2024

View reviewed changes

Merge branch 'main' into issue-10284

02fe622

codeclimate bot reviewed Jun 6, 2024

View reviewed changes

fix(useWagmi.ts): remove base and added imx

44665b0

codeclimate bot reviewed Jun 6, 2024

View reviewed changes

ref(ConnnectEvm.vue): check chain id on wallet connect

9ba8184

codeclimate bot reviewed Jun 6, 2024

View reviewed changes

vikiival changed the base branch from main to feat/evm/v0 June 6, 2024 13:08

Merge branch 'main' into issue-10284

9274610

vikiival merged commit 578f43b into kodadot:feat/evm/v0 Jun 6, 2024
8 checks passed

vikiival added this to the Milestone 2 milestone Jun 6, 2024

hassnian mentioned this pull request Jul 27, 2024

Support Adding Funds on EVM #10695

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make EVM wallet connector #10354

feat: Make EVM wallet connector #10354

hassnian commented May 27, 2024 •

edited

Loading

netlify bot commented May 27, 2024 •

edited

Loading

socket-security bot commented May 27, 2024 •

edited

Loading

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

Jarsen136 commented Jun 4, 2024

prury commented Jun 4, 2024

prury commented Jun 4, 2024

codeclimate bot left a comment

codeclimate bot left a comment

hassnian commented Jun 5, 2024

hassnian commented Jun 5, 2024 •

edited

Loading

exezbcz commented Jun 5, 2024

exezbcz commented Jun 6, 2024

codeclimate bot left a comment

hassnian commented Jun 6, 2024 •

edited

Loading

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot commented Jun 6, 2024

sonarcloud bot commented Jun 6, 2024

hassnian commented Jun 6, 2024

feat: Make EVM wallet connector #10354

feat: Make EVM wallet connector #10354

Conversation

hassnian commented May 27, 2024 • edited Loading

PR Type

Context

Needs QA check

Needs Design check

Did your issue had any of the "$" label on it?

Screenshot 📸

netlify bot commented May 27, 2024 • edited Loading

✅ Deploy Preview for koda-canary ready!

socket-security bot commented May 27, 2024 • edited Loading

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

Jarsen136 commented Jun 4, 2024

prury commented Jun 4, 2024

prury commented Jun 4, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

hassnian commented Jun 5, 2024

hassnian commented Jun 5, 2024 • edited Loading

exezbcz commented Jun 5, 2024

exezbcz commented Jun 6, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

hassnian commented Jun 6, 2024 • edited Loading

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jun 6, 2024

sonarcloud bot commented Jun 6, 2024

Quality Gate passed

hassnian commented Jun 6, 2024

hassnian commented May 27, 2024 •

edited

Loading

netlify bot commented May 27, 2024 •

edited

Loading

socket-security bot commented May 27, 2024 •

edited

Loading

hassnian commented Jun 5, 2024 •

edited

Loading

hassnian commented Jun 6, 2024 •

edited

Loading