-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve drop first load speed #10379
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have applied the similar logic of lazy load in two places. How about making a common lazy wrapper component?
<div>
<div ref="target"></div>
<template v-if="targetIsVisible">
<slot />
</template>
<div>
const target = ref<HTMLHtmlElement>()
const targetIsVisible = useOnceIsVisible(target)
drop gallery item is loaded once the divider is seen
In case of one day we removed the divider line on the drop page.
done |
Code Climate has analyzed commit f1ca0eb and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite really difficult to see the differences. but, lets go
PR Type
Context
fetching the drop a little before inside the
setup
made some components lazy
drop gallery item is loaded once the divider is seen
Ref All Drops are very slow #10307
Needs QA check
Did your issue had any of the "$" label on it?
Screenshot 📸