Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Top Collection representation "streched" (only Base) #10414

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 6, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

The button to choose time period also disappears:

atm volume on base is not tracked, that's why it was decided to hide the period buttons

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-06-06 at 13 08 49@2x

@hassnian hassnian requested a review from a team as a code owner June 6, 2024 08:13
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team June 6, 2024 08:13
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4985bdc
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66616fa3425bde000843a07f
😎 Deploy Preview https://deploy-preview-10414--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jun 6, 2024

Code Climate has analyzed commit 4985bdc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival added this to the Milestone 2 milestone Jun 6, 2024
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 6, 2024
@vikiival
Copy link
Member

vikiival commented Jun 7, 2024

cc @Jarsen136 @preschian

@vikiival
Copy link
Member

vikiival commented Jun 7, 2024

TL;DR of your changes ?

@hassnian
Copy link
Contributor Author

hassnian commented Jun 8, 2024

TL;DR of your changes ?

there was a bug in the fillRows feature, which tries to get cols filled by all rows, now if this can't be fulfilled, it will use to the normal cols amount

@vikiival vikiival merged commit 13441bb into kodadot:main Jun 10, 2024
19 checks passed
@vikiival vikiival mentioned this pull request Jun 12, 2024
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Collection representation "streched" (only Base)
3 participants