Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create profile when not connected #10456

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 11, 2024 12:27
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team June 11, 2024 12:27
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1a6fbbf
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66694c649c2331000856348c
😎 Deploy Preview https://deploy-preview-10456--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury requested review from vikiival and removed request for daiagi June 11, 2024 13:16
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 11, 2024
components/profile/ProfileDetail.vue Outdated Show resolved Hide resolved
components/profile/ProfileDetail.vue Outdated Show resolved Hide resolved
Jarsen136 and others added 2 commits June 12, 2024 09:20
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit 1a6fbbf and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival added this pull request to the merge queue Jun 12, 2024
Merged via the queue into kodadot:main with commit a84b770 Jun 12, 2024
19 checks passed
@vikiival vikiival mentioned this pull request Jun 12, 2024
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create profile when not connected
4 participants