Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use iframe to image on code-checker #10526

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copy link

cloudflare-workers-and-pages bot commented Jun 22, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59dd94a
Status: ✅  Deploy successful!
Preview URL: https://447eff58.kodaart-production.pages.dev
Branch Preview URL: https://chore--use-iframe-to-image-o.kodaart-production.pages.dev

View logs

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 59dd94a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6683b768461d4e0008247f29
😎 Deploy Preview https://deploy-preview-10526--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian preschian marked this pull request as ready for review June 22, 2024 04:31
@preschian preschian requested a review from a team as a code owner June 22, 2024 04:31
@preschian preschian requested review from vikiival and hassnian and removed request for a team June 22, 2024 04:31
@hassnian
Copy link
Contributor

hassnian commented Jun 22, 2024

something is wrong , canary is working fine

CleanShot 2024-06-22 at 10 25 52

@preschian
Copy link
Member Author

something is wrong , canary is working fine

oh, did you try on koda-art preview? for now try on netlify preview instead

the reason is, public/sandbox.html doesn't work on nuxt + cf-pages: https://github.com/kodadot/nft-gallery/blob/main/public/sandbox.html

on cf-pages, we proxy the routes to static bucket in this worker: https://github.com/kodadot/workers/blob/2fd6a8e1b75b724aab3c6c7ee11b1aabaebf5b67/services/ogi-route/src/index.ts#L7-L9

@preschian
Copy link
Member Author

additional context, one artist need this

Screenshot 2024-06-25 at 12 24 32

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 the constants and LGTM

Copy link

codeclimate bot commented Jul 2, 2024

Code Climate has analyzed commit 59dd94a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jul 2, 2024

@vikiival vikiival enabled auto-merge July 2, 2024 08:17
@vikiival vikiival added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 2c68e37 Jul 2, 2024
21 checks passed
@vikiival vikiival deleted the chore--use-iframe-to-image-on-code-checker branch July 2, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants