-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use iframe to image on code-checker #10526
Conversation
Deploying koda-art-prod with Cloudflare Pages
|
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oh, did you try on koda-art preview? for now try on netlify preview instead the reason is, public/sandbox.html doesn't work on nuxt + cf-pages: https://github.com/kodadot/nft-gallery/blob/main/public/sandbox.html on cf-pages, we proxy the routes to static bucket in this worker: https://github.com/kodadot/workers/blob/2fd6a8e1b75b724aab3c6c7ee11b1aabaebf5b67/services/ogi-route/src/index.ts#L7-L9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 the constants and LGTM
…om:kodadot/nft-gallery into chore--use-iframe-to-image-on-code-checker
Code Climate has analyzed commit 59dd94a and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context