Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove minted out collection from landing #10668

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 22, 2024 17:38
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team July 22, 2024 17:38
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0b1e772
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66b4b9a57a480a0008b69df2
😎 Deploy Preview https://deploy-preview-10668--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if we could filter this out on the worker side

then we wouldn't have to keep track of minted out drops and update the limit here

components/drops/useDrops.ts Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jul 23, 2024

Code Climate has analyzed commit 4afc2aa and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

would be nice if we could filter this out on the worker side

then we wouldn't have to keep track of minted out drops and update the limit here

Yes, I have already thought about it. The reason stop me from implementing it is that the worker side does not have the correct stats of minted.

@Jarsen136 Jarsen136 enabled auto-merge July 24, 2024 11:13
@vikiival
Copy link
Member

vikiival commented Aug 8, 2024

You have conflicts @Jarsen136

@Jarsen136 Jarsen136 added this pull request to the merge queue Aug 8, 2024
Merged via the queue into kodadot:main with commit c1fc3bf Aug 8, 2024
19 of 20 checks passed
@Jarsen136 Jarsen136 deleted the issue-10664 branch August 8, 2024 12:27
Copy link

sonarcloud bot commented Aug 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove minted out collection from landing
3 participants