Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade sass version #10672

Merged
merged 3 commits into from
Jul 31, 2024
Merged

chore: downgrade sass version #10672

merged 3 commits into from
Jul 31, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 23, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Downgrade sass version to suppress warning on development mode. until oruga+bulma removed

Related:

Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab39804
Status: ✅  Deploy successful!
Preview URL: https://2432b4f1.kodaart-production.pages.dev
Branch Preview URL: https://chore--downgrade-sass-versio.kodaart-production.pages.dev

View logs

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ab39804
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66aa00b06eea280007f7e201
😎 Deploy Preview https://deploy-preview-10672--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jul 23, 2024

Code Climate has analyzed commit b953880 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review July 23, 2024 15:28
@preschian preschian requested a review from a team as a code owner July 23, 2024 15:28
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team July 23, 2024 15:28
@vikiival vikiival requested review from hassnian and removed request for vikiival July 24, 2024 11:15
@preschian
Copy link
Member Author

for context, this is for sass warning on terminal when running development mode

Screenshot 2024-07-30 at 14 09 56

@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 30, 2024
@Jarsen136
Copy link
Contributor

cf build failed
image

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing

@preschian
Copy link
Member Author

should be fine now, not related to this PR

Screenshot 2024-07-31 at 06 05 15

Copy link

sonarcloud bot commented Jul 31, 2024

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/lodash@4.17.21

View full report↗︎

@vikiival vikiival added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 95579c3 Jul 31, 2024
21 checks passed
@vikiival vikiival deleted the chore--downgrade-sass-version branch July 31, 2024 10:04
This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants