Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some eslint #10677

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chore: fix some eslint #10677

merged 3 commits into from
Jul 24, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 23, 2024 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

merge this one first: #10671

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024 •
edited
Loading

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b88694
Status: ✅  Deploy successful!
Preview URL: https://1c1cd76c.kodaart-production.pages.dev
Branch Preview URL: https://chore--fix-some-eslint.kodaart-production.pages.dev

View logs

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0b88694
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66a0ea7c1797f80008fa8377
😎 Deploy Preview https://deploy-preview-10677--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 mentioned this pull request Jul 24, 2024
Merged
5 tasks
Base automatically changed from chore--pnpm-run-lint-fix to main July 24, 2024 11:15
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit 0b88694 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@preschian preschian marked this pull request as ready for review July 24, 2024 13:57
@preschian preschian requested a review from a team as a code owner July 24, 2024 13:57
@preschian preschian requested review from vikiival and hassnian and removed request for a team July 24, 2024 13:57
@vikiival vikiival merged commit f93f7aa into main Jul 24, 2024
20 of 21 checks passed
@vikiival vikiival deleted the chore--fix-some-eslint branch July 24, 2024 14:48
This was referenced Aug 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

@hassnian hassnian Awaiting requested review from hassnian hassnian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reviewdog is failing Fix leftover eslint issues
2 participants
@preschian @vikiival