Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pricing on drop cards #10741

Merged
merged 3 commits into from
Aug 12, 2024
Merged

feat: Pricing on drop cards #10741

merged 3 commits into from
Aug 12, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 5, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-08-05 at 12 03 38@2x

@hassnian hassnian requested a review from a team as a code owner August 5, 2024 07:05
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team August 5, 2024 07:05
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c53cec4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66b5b1f553ae92000831bb9c
😎 Deploy Preview https://deploy-preview-10741--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival mentioned this pull request Aug 5, 2024
Closed
@exezbcz
Copy link
Member

exezbcz commented Aug 7, 2024

smol

image

lets put "free" instead of 0 USD

@exezbcz exezbcz added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

hassnian commented Aug 9, 2024 •
edited
Loading

smol
lets put "free" instead of 0 USD

@exezbcz
Copy link
Member

exezbcz commented Aug 10, 2024

yeah information overload but lets go, Japanese design

@hassnian hassnian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked S-visual-ok-✅ and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 11, 2024
@vikiival vikiival added this pull request to the merge queue Aug 12, 2024
Merged via the queue into kodadot:main with commit 94f1bfc Aug 12, 2024
22 checks passed
This was referenced Aug 13, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@exezbcz exezbcz exezbcz approved these changes

@JustLuuuu JustLuuuu Awaiting requested review from JustLuuuu

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pricing on drop cards
5 participants
@hassnian @exezbcz @preschian @Jarsen136 @vikiival