Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure that EVM connectors work properly #10762

Merged
merged 15 commits into from
Aug 10, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Aug 6, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3d3c6c3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66b5a2bf328f0800081b160d
😎 Deploy Preview https://deploy-preview-10762--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor Author

hassnian commented Aug 6, 2024

@vikiival @exezbcz can you test and let me know ?

now it should allow you sign with any evm wallet*

*I have found another case that is not working (currently investigating that), connecting directly with coinbase works , but if you connect with any evm wallet and disconnect and try to connect with coinbase that's not working for me.

@exezbcz
Copy link
Member

exezbcz commented Aug 6, 2024

@hassnian nice, managed to sign a drop mint, good job

@vikiival
Copy link
Member

vikiival commented Aug 6, 2024

  1. Metamask, Talisman works smoothly

  2. Coinbase works after hard reload

but if you connect with any evm wallet and disconnect and try to connect with coinbase that's not working for me.

I was able to reproduce this one

@hassnian hassnian marked this pull request as ready for review August 8, 2024 09:10
@hassnian hassnian requested a review from a team as a code owner August 8, 2024 09:10
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team August 8, 2024 09:10
@hassnian
Copy link
Contributor Author

hassnian commented Aug 8, 2024

but if you connect with any evm wallet and disconnect and try to connect with coinbase that's not working for me.

I was able to reproduce this one

took some time to debug, the issue was that we were clearing the entire localstorage when logging out, and coinbase wallet was using that to store data


should work now , tried with multiple wallets installed and all flows work.

@vikiival @JustLuuuu @kodadot/internal-dev need help testing, let me know if anyone is experiencing any other issue.

pls connect with a wallet try minting (the connected wallet should appear) , disconnect that wallet and repeat the same process with another wallet.

thanks

@vikiival
Copy link
Member

vikiival commented Aug 8, 2024

You have some conflicts

@vikiival vikiival added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 8, 2024
@preschian
Copy link
Member

pls connect with a wallet try minting (the connected wallet should appear) , disconnect that wallet and repeat the same process with another wallet.

This one looks fine

But when I want to mint, it shows the onramp button on the free drop. After reloading, it works

After minting and wanna switch to another wallet, it shows both vm. Which one is correct? On reload, it only shows the web3modal button

@vikiival
Copy link
Member

vikiival commented Aug 8, 2024

@preschian pls open new issues

Copy link

sonarcloud bot commented Aug 9, 2024

@hassnian
Copy link
Contributor Author

hassnian commented Aug 9, 2024

You have some conflicts

done

@preschian pls open new issues

opened two new issues

@vikiival
Copy link
Member

vikiival commented Aug 9, 2024

Pls @kodadot/internal-dev make review

@preschian
Copy link
Member

opened two new issues

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that EVM connectors work properly
7 participants