Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize subscription with polling #10764

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 6, 2024 13:57
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team August 6, 2024 13:57
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8c66730
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66c6f39ef359a30008ff38bc
😎 Deploy Preview https://deploy-preview-10764--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice and should be able to address the issue. It works fine; I just tested drops on AssetHub.

It's noticeably slower since it's using a polling interval. However, this should be fixed with: #10607

I just noticed that drops on AHK, such as Meadow and Complexity, show incorrect minted/max supply counts. This should be fixed with: #10607

Don't forget to review those PRs, guys. Those PRs are ready for testing and should improve the minting experience on AssetHub.

Copy link

socket-security bot commented Aug 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@wagmi/core@2.12.2), npm/@wagmi/vue@0.0.37)

View full report↗︎

@vikiival
Copy link
Member

vikiival commented Aug 19, 2024

cc @Jarsen136

@Jarsen136 Jarsen136 added this pull request to the merge queue Aug 22, 2024
Copy link

sonarcloud bot commented Aug 22, 2024

Merged via the queue into kodadot:main with commit 6c84032 Aug 22, 2024
19 of 21 checks passed
@Jarsen136 Jarsen136 deleted the issue-10749 branch August 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize subscription
4 participants