Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create offer on AssetHub #10842

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 16, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

This PR only contains the basic functionality of creating offer on ahp/ahk. There is still some missing from the UI perspective.

I will create more separate issue base on #10807

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Kapture

image

ahp: https://assethub-polkadot.subscan.io/extrinsic/0x27a32bce6bfa4b91e29523e89bf736bb9b7e7c59eb157851c7ef47ee4f4f8549
ahk: https://assethub-kusama.subscan.io/extrinsic/0x5f8f5b599d088141b570095014fdad3181def781d47a2fe0bc0d10d4fe7e4ebc

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 16, 2024 17:31
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team August 16, 2024 17:31
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit dd212f9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66c47c0f78c3330008b473f7
😎 Deploy Preview https://deploy-preview-10842--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

image

@Jarsen136
Copy link
Contributor Author

image

fixed deepscan.
I would ignore these warnings on codeclimate.

components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakeOffer.vue Show resolved Hide resolved
stores/makeOffer.ts Show resolved Hide resolved
components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakingOfferItemDetails.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Aug 17, 2024

i guess the frontend work will be done later?

@exezbcz
Copy link
Member

exezbcz commented Aug 17, 2024

so from what i see is missing:

  • offer duration
  • stats of the collection - best offer and floor

can be done in the other issues

@Jarsen136
Copy link
Contributor Author

so from what i see is missing:

  • offer duration
  • stats of the collection - best offer and floor

can be done in the other issues

I would implement them on #10843

For now, the offer duration is set to a fixed 7 days.

@vikiival vikiival requested a review from hassnian August 18, 2024 18:46
@vikiival
Copy link
Member

vikiival commented Aug 18, 2024

cc @preschian

components/common/CartItemDetails.vue Outdated Show resolved Hide resolved
components/offer/MakeOffer.vue Outdated Show resolved Hide resolved
components/offer/MakingOfferItemDetails.vue Outdated Show resolved Hide resolved
composables/autoTeleport/useAutoTeleportActionButton.ts Outdated Show resolved Hide resolved
stores/makeOffer.ts Show resolved Hide resolved
components/common/listingCart/ListingCartModal.vue Outdated Show resolved Hide resolved
@hassnian
Copy link
Contributor

hassnian commented Aug 19, 2024

@Jarsen136 some changes are not updated, otherwise we are almost there :D

@Jarsen136
Copy link
Contributor Author

@Jarsen136 some changes are not updated, otherwise we are almost there :D

All should be updated now. Could you review it again?

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 missing #10842 (comment)

Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
@hassnian
Copy link
Contributor

hassnian commented Aug 20, 2024

@Jarsen136 reviewdog it's failing
CleanShot 2024-08-20 at 15 05 28@2x

@Jarsen136
Copy link
Contributor Author

@Jarsen136 reviewdog it's failing CleanShot 2024-08-20 at 15 05 28@2x

fixed

Copy link

sonarcloud bot commented Aug 20, 2024

@vikiival
Copy link
Member

Screenshot 2024-08-20 at 19 32 27

@Jarsen136
Copy link
Contributor Author

Screenshot 2024-08-20 at 19 32 27

I re-run the test and then it turns to green.

image

@Jarsen136
Copy link
Contributor Author

review request cc @preschian

@vikiival
Copy link
Member

Can confirm that:

  1. Offer button produces valid transaction

https://assethub-polkadot.subscan.io/extrinsic/0x6767688c556290af13e0842b5fcd17e25a1daac7b7d6bfc7c18e88e63d574489

  1. User experience is smooth

Screenshot 2024-08-23 at 10 33 51

  1. Offer is claimable as it should be

Thanks @kodadot/internal-dev for Reviews
Kudos to @Jarsen136 for impl.

let's continue ^-^

@Jarsen136 Jarsen136 added this pull request to the merge queue Aug 26, 2024
Merged via the queue into kodadot:main with commit d1b6074 Aug 26, 2024
21 of 22 checks passed
@Jarsen136 Jarsen136 deleted the feat-asset-hub-offer branch August 26, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create offer on AssetHub
5 participants