Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create offer modal & signing design #10909

Merged
merged 18 commits into from
Sep 9, 2024
Merged

feat: Create offer modal & signing design #10909

merged 18 commits into from
Sep 9, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 26, 2024 •
edited
Loading

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

https://deploy-preview-10909--koda-canary.netlify.app/ahp/gallery/166-2408213503

image image image

Kapture

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 26, 2024 20:53
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team August 26, 2024 20:53
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f8a3015
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66def02127514d000873575a
😎 Deploy Preview https://deploy-preview-10909--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor

hassnian commented Aug 27, 2024 •
edited
Loading

@Jarsen136 some bugs that I found

  1. top section of modal it's breaking on ahk
CleanShot.2024-08-27.at.10.59.46.mp4
  1. after modal is closed, the input and main button are not synced, the input should be
  • either cleared if the transaction was completed
  • or not cleared if it was closed without any transaction made
  • or always cleared
  1. price input should be more precise, switching between token and usd price should give me the same value , like the transfer page tabs
CleanShot.2024-08-27.at.13.07.59.mp4
  1. I was able to start a transaction to make an offer but I got these errors, if I don't have enough funds I should not be able to even start a transaction

CleanShot 2024-08-27 at 12 30 43@2x

only error that I have on the console, might be related

@Jarsen136
Copy link
Contributor Author

@Jarsen136 top section of modal it's breaking on ahk

Fixed so it would not be broken. However, the indexer for offers feature is only available on ahp, so that the highest offer would be shown correctly only on ahp.

@vikiival
Copy link
Member

breaking on ahk
the indexer for offers feature is only available on ahp

I have some metadata issues on ahk therefore it's going ultra-slooooooow

@Jarsen136
Copy link
Contributor Author

@Jarsen136 some bugs that I found

@hassnian Thanking for testing. All should have been fixed. Let me know I'm missing something.

@hassnian
Copy link
Contributor

@Jarsen136 on auto teleport the modal is closing , see

CleanShot.2024-08-28.at.11.02.16.mp4

@Jarsen136
Copy link
Contributor Author

@Jarsen136 on auto teleport the modal is closing , see

Fixed

@Jarsen136 Jarsen136 changed the title feat: Create offer modal design feat: Create offer modal & signing design Aug 28, 2024
hassnian
hassnian approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small

composables/transaction/transactionOffer.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

vikiival commented Sep 4, 2024

cc @preschian for review
cc @exezbcz for design

@vikiival
Copy link
Member

vikiival commented Sep 6, 2024

cc @preschian

preschian
preschian approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItem.vue Show resolved Hide resolved
components/offer/OfferPriceInput.vue Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@exezbcz exezbcz mentioned this pull request Sep 9, 2024
Closed
@vikiival vikiival added this pull request to the merge queue Sep 9, 2024
Merged via the queue into kodadot:main with commit a596f34 Sep 9, 2024
20 of 22 checks passed
@exezbcz exezbcz mentioned this pull request Sep 9, 2024
Closed
This was referenced Sep 9, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival left review comments

@hassnian hassnian hassnian approved these changes

Assignees

@exezbcz exezbcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2. creating offer signing design 1. Create offer modal design
5 participants
@Jarsen136 @hassnian @vikiival @preschian @exezbcz