fix: balance fetching bugs

[hassnian]

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Sub wallet balance not loading when evm chain is selected #10933
• Fixes: sub wallet malformatted
  • if sub wallet is connected and user lands on /base the address is not formatted correctly
• Fix: on wallet switch balance from others are not cleared

CleanShot.2024-09-06.at.12.10.40.mp4

• Fixes: wallet vm and chain vm mismatch balance fetch using identityStore.fetchBalance

covers case where wallet vm and current chain's vm do not match, since prefix is unknown at that moment we are resorting to a fallbacks instate of not making a balance fetch

Example

evm wallet is connected , chain is ahp , navbar makes a balance fetch

this happens in the navbar and sidebar, in these scenarios what prefix should be fetched ?

@kodadot/internal-dev pls feel free to suggest any other solution.

Screenshot 📸

• My fix has changed something on UI;

CleanShot.2024-09-06.at.12.05.08.mp4

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	b27f782
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/66dea440f8144200088c912a
😎 Deploy Preview	https://deploy-preview-10936--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Jarsen136]

evm wallet is connected , chain is ahp , navbar makes a balance fetch

this happens in the navbar and sidebar, in these scenarios what prefix should be fetched ?

IMO, the balance should always match the current connect wallet.
For example:
Connect with EVM wallet: fetch balance on base \ mantle etc.
Connect with SUB wallet: fetch balance on ahp\ahk\dot etc.

[hassnian]

evm wallet is connected , chain is ahp , navbar makes a balance fetch
this happens in the navbar and sidebar, in these scenarios what prefix should be fetched ?

IMO, the balance should always match the current connect wallet. For example: Connect with EVM wallet: fetch balance on base \ mantle etc. Connect with SUB wallet: fetch balance on ahp\ahk\dot etc.

method: identityStore.fetchBalance

if evm wallet is connected and you are on ahp chain what chain should the balance to be fetched, 'base', 'imx' , etc
same when a sub wallet is connected and you are on evm chain.

let me know if it makes sense.

[Jarsen136]

if evm wallet is connected and you are on ahp chain what chain should the balance to be fetched, 'base', 'imx' , etc

It's also what I want.

same when a sub wallet is connected and you are on evm chain.

I'm not sure what you mean by the same. In this case, it should shows all the balance on sub, dot ahp ahk etc.

In short, the balances should always correspond to the type of wallet, regardless of the network prefix.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[vikiival]

pls @kodadot/internal-dev waiting for review 🥺

[Jarsen136]

work for me